Topology suppression #95
Merged
+56
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Adds “topology suppression” to the clustering pipeline to zero-out pixels that don’t match an expected neighborhood pattern, aiming to improve cluster quality before reconstruction.
Changes:
- Introduces
ClusteringBase.topology_suppress()to suppress pixels that don’t match the expected neighbor topology and re-sort outputs. - Integrates topology suppression into
ClusteringNN.run()prior to trimming zero-suppressed pixels.
Comments suppressed due to low confidence (1)
src/hexsample/clustering.py:331
- After
topology_suppress,pha,col, androwhave already been sliced/reordered to match the selected pixels. Reusingmask(which still contains indices into the original 7-pixel arrays) to indexcol/row/phawill produce incorrect selections and can raise IndexError whenmaskcontains values >len(col)-1. Use a boolean keep mask derived from the post-suppression arrays (e.g.,keep = pha > 0) and apply it directly topha/col/row, or resetmasktonp.arange(len(pha))[pha > 0]before indexing.
mask = mask[pha > 0]
# Trim the relevant arrays.
col = col[mask]
row = row[mask]
pha = pha[mask]
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.